Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Thomas Goirand
Hi,

Michael and Thierry,

After applying:
https://github.com/openstack/nova/commit/efaacdaee116388234558e2682b647d41fe5b149

in Essex Nova 2012.1.1-15 in Debian SID, Jules <[hidden email]>
reported this:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703242

So, it seems that last security patch in SID broke nova-console. Is it
possible? Is it known? Does Ubuntu have the problem as well? Is there a fix?

I've submit but #703242 so that the package doesn't migrate from SID to
Wheezy with this problem. At this time of the release of the next Debian
testing, such an RC bug isn't welcome. A quick resolution would be much
appreciated by the release team.

Cheers,

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Michael Still

It strikes me as very unlikely that this is related to the fixed ips change. I'm travelling today but I will try and find wifi at the airport to double check.

Mikal

On Mar 17, 2013 10:01 AM, "Thomas Goirand" <[hidden email]> wrote:
Hi,

Michael and Thierry,

After applying:
https://github.com/openstack/nova/commit/efaacdaee116388234558e2682b647d41fe5b149

in Essex Nova 2012.1.1-15 in Debian SID, Jules <[hidden email]>
reported this:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703242

So, it seems that last security patch in SID broke nova-console. Is it
possible? Is it known? Does Ubuntu have the problem as well? Is there a fix?

I've submit but #703242 so that the package doesn't migrate from SID to
Wheezy with this problem. At this time of the release of the next Debian
testing, such an RC bug isn't welcome. A quick resolution would be much
appreciated by the release team.

Cheers,

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Jason Kölker-2
On Sun, Mar 17, 2013 at 1:19 PM, Michael Still <[hidden email]> wrote:
> It strikes me as very unlikely that this is related to the fixed ips change.
> I'm travelling today but I will try and find wifi at the airport to double
> check.

I think its actually this commit, which removed context from being passed in:

https://github.com/openstack/nova/commit/e02b45976fe4468ad70c886255f1af71652ce4f9

Looks like it was "broken" prior to that though as well.

Happy Hacking!

7-11

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Vishvananda Ishaya
In reply to this post by Thomas Goirand
It looks more like this is a result of merging this fix:

https://review.openstack.org/#/c/22872/

You probably need this one as well if you don't have it:

https://review.openstack.org/#/c/23036/

Vish

On Mar 17, 2013, at 9:01 AM, Thomas Goirand <[hidden email]> wrote:

> Hi,
>
> Michael and Thierry,
>
> After applying:
> https://github.com/openstack/nova/commit/efaacdaee116388234558e2682b647d41fe5b149
>
> in Essex Nova 2012.1.1-15 in Debian SID, Jules <[hidden email]>
> reported this:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703242
>
> So, it seems that last security patch in SID broke nova-console. Is it
> possible? Is it known? Does Ubuntu have the problem as well? Is there a fix?
>
> I've submit but #703242 so that the package doesn't migrate from SID to
> Wheezy with this problem. At this time of the release of the next Debian
> testing, such an RC bug isn't welcome. A quick resolution would be much
> appreciated by the release team.
>
> Cheers,
>
> Thomas
>
> _______________________________________________
> OpenStack-dev mailing list
> [hidden email]
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Vishvananda Ishaya
In reply to this post by Jason Kölker-2
As Jason says, it looks like the second patch here that fixed the unit tests actually
broke the binary:

https://review.openstack.org/#/c/23036/


On Mar 17, 2013, at 11:27 AM, Jason Kölker <[hidden email]> wrote:

> On Sun, Mar 17, 2013 at 1:19 PM, Michael Still <[hidden email]> wrote:
>> It strikes me as very unlikely that this is related to the fixed ips change.
>> I'm travelling today but I will try and find wifi at the airport to double
>> check.
>
> I think its actually this commit, which removed context from being passed in:
>
> https://github.com/openstack/nova/commit/e02b45976fe4468ad70c886255f1af71652ce4f9
>
> Looks like it was "broken" prior to that though as well.
>
> Happy Hacking!
>
> 7-11
>
> _______________________________________________
> OpenStack-dev mailing list
> [hidden email]
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Vishvananda Ishaya
In reply to this post by Thomas Goirand
Potential fix here:

https://review.openstack.org/24608

Vish

On Mar 17, 2013, at 9:01 AM, Thomas Goirand <[hidden email]> wrote:

> Hi,
>
> Michael and Thierry,
>
> After applying:
> https://github.com/openstack/nova/commit/efaacdaee116388234558e2682b647d41fe5b149
>
> in Essex Nova 2012.1.1-15 in Debian SID, Jules <[hidden email]>
> reported this:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703242
>
> So, it seems that last security patch in SID broke nova-console. Is it
> possible? Is it known? Does Ubuntu have the problem as well? Is there a fix?
>
> I've submit but #703242 so that the package doesn't migrate from SID to
> Wheezy with this problem. At this time of the release of the next Debian
> testing, such an RC bug isn't welcome. A quick resolution would be much
> appreciated by the release team.
>
> Cheers,
>
> Thomas
>
> _______________________________________________
> OpenStack-dev mailing list
> [hidden email]
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Michael Still
It seems like Vish has this handled, so I'm going to bravely run away.

Michael

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

postmaster@ispire.me
Am 17.03.13 21:38, schrieb Michael Still:
It seems like Vish has this handled, so I'm going to bravely run away.

Michael
patchsets: <a href="cid:part1.02050107.02050304@ispire.me" moz-do-not-send="false">https://review.openstack.org/#/c/23768/ and <a href="cid:part2.08040006.06040703@ispire.me" moz-do-not-send="false">https://review.openstack.org/#/c/24608/
solved my bug report finally. Thanks!


Greets
Jules

http://ispire.me

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: [Openstack-devel] Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Jules
In reply to this post by Vishvananda Ishaya
Am 25.03.13 10:40, schrieb Julien Cristau:

> On Sun, Mar 24, 2013 at 16:08:36 +0100, [hidden email] wrote:
>
>> Hi guys,
>>
>> i've provided a working patchset for this issue a couple of days
>> ago: http://ispire.me/fix-for-broken-vnc-console-on-openstack-essex-under-debianubuntu/
>>
>> It's built out of the two code reviews i mentioned before. Maybe the
>> maintainers can finally put them into the next package release.
>>
> Unfortunately you use a silly email address which means your mails don't
> get to the bug tracker.  Care to use something sensible without
> postmaster as localpart?
>
> Cheers,
> Julien

I try again.

Hi guys,

i've provided a working patchset for this issue a couple of days ago:
http://ispire.me/fix-for-broken-vnc-console-on-openstack-essex-under-debianubuntu/ 


It's built out of the two code reviews i mentioned before. Maybe the
maintainers can finally put them into the next package release.

There we go :-)

Kind Regards,
Jules

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Thomas Goirand
On 03/25/2013 06:26 PM, Jules wrote:

> Am 25.03.13 10:40, schrieb Julien Cristau:
>> On Sun, Mar 24, 2013 at 16:08:36 +0100, [hidden email] wrote:
>>
>>> Hi guys,
>>>
>>> i've provided a working patchset for this issue a couple of days
>>> ago:
>>> http://ispire.me/fix-for-broken-vnc-console-on-openstack-essex-under-debianubuntu/
>>>
>>>
>>> It's built out of the two code reviews i mentioned before. Maybe the
>>> maintainers can finally put them into the next package release.
>>>
>> Unfortunately you use a silly email address which means your mails don't
>> get to the bug tracker.  Care to use something sensible without
>> postmaster as localpart?
>>
>> Cheers,
>> Julien
>
> I try again.
>
> Hi guys,
>
> i've provided a working patchset for this issue a couple of days ago:
> http://ispire.me/fix-for-broken-vnc-console-on-openstack-essex-under-debianubuntu/
>
>
> It's built out of the two code reviews i mentioned before. Maybe the
> maintainers can finally put them into the next package release.
>
> There we go :-)
>
> Kind Regards,
> Jules

Hi,

While I may apply any random fix, that's not really what I would like. I
would very much prefer to have an upstream APPROVED patch, which isn't
just waiting for the review to end.

Vish, TTX, Michael, do you know if this will happen anytime soon? Or do
you think that the patch from Jules is actually ok, and I should apply
it and release it in Debian? I really need your input here.

Cheers,

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Russell Bryant
On 03/25/2013 12:44 PM, Thomas Goirand wrote:
> While I may apply any random fix, that's not really what I would like. I
> would very much prefer to have an upstream APPROVED patch, which isn't
> just waiting for the review to end.
>
> Vish, TTX, Michael, do you know if this will happen anytime soon? Or do
> you think that the patch from Jules is actually ok, and I should apply
> it and release it in Debian? I really need your input here.

There's a patch here:

    https://review.openstack.org/#/c/23768/

It is waiting on review from the essex-maint team.  I'm trying to chase
down who has the permissions to review and approve it now.

--
Russell Bryant

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Mac Innes, Kiall

On 25/03/13 17:20, Russell Bryant wrote:
> I'm trying to chase down who has the permissions to review and approve it now.

This is the list you're looking for I think:

https://launchpad.net/~openstack-stable-maint/+members

Kiall Mac Innes
HP Cloud Services - DNSaaS

Mobile:   +353 86 345 9333
Landline: +353 1 524 2177
GPG:      E9498407

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Thierry Carrez
In reply to this post by Thomas Goirand
Thomas Goirand wrote:
> Vish, TTX, Michael, do you know if this will happen anytime soon? Or do
> you think that the patch from Jules is actually ok, and I should apply
> it and release it in Debian? I really need your input here.

I'll look into it and try to corner Michael, Vish and the Essex stable
maintenance folks about it today.

Cheers,

--
Thierry Carrez (ttx)
Release Manager, OpenStack

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Thierry Carrez
In reply to this post by Mac Innes, Kiall
Mac Innes, Kiall wrote:
> On 25/03/13 17:20, Russell Bryant wrote:
>> I'm trying to chase down who has the permissions to review and approve it now.
>
> This is the list you're looking for I think:
>
> https://launchpad.net/~openstack-stable-maint/+members

No, the stable/essex branch is actually maintained by this team:
https://launchpad.net/~openstack-essex-maint/+members

I'm pretty sure Dave would love to have help and company :)

--
Thierry Carrez (ttx)
Release Manager, OpenStack

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Thierry Carrez
In reply to this post by Russell Bryant
Russell Bryant wrote:

> On 03/25/2013 12:44 PM, Thomas Goirand wrote:
>> While I may apply any random fix, that's not really what I would like. I
>> would very much prefer to have an upstream APPROVED patch, which isn't
>> just waiting for the review to end.
>>
>> Vish, TTX, Michael, do you know if this will happen anytime soon? Or do
>> you think that the patch from Jules is actually ok, and I should apply
>> it and release it in Debian? I really need your input here.
>
> There's a patch here:
>
>     https://review.openstack.org/#/c/23768/

This patch was merged to the stable/essex branch now, so it's the
"approved" fix. FWIW it's the same as Jules' proposed patch.

Hope this closes this issue for good.

--
Thierry Carrez (ttx)
Release Manager, OpenStack

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: Bug#703242: Bugging issue with nova-consoleauth on newest nova build 2012.1.1-15

Daviey Walker
In reply to this post by Thierry Carrez
On 26 March 2013 09:41, Thierry Carrez <[hidden email]> wrote:

> Mac Innes, Kiall wrote:
>> On 25/03/13 17:20, Russell Bryant wrote:
>>> I'm trying to chase down who has the permissions to review and approve it now.
>>
>> This is the list you're looking for I think:
>>
>> https://launchpad.net/~openstack-stable-maint/+members
>
> No, the stable/essex branch is actually maintained by this team:
> https://launchpad.net/~openstack-essex-maint/+members
>
> I'm pretty sure Dave would love to have help and company :)
>

Yes, that would be greatly appreciated! :)

Thanks.

--
Kind Regards,

Dave Walker <[hidden email]>
Engineering Manager,
Ubuntu Server

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev