[horizon] Removing the .mo files from Horizon git

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[horizon] Removing the .mo files from Horizon git

Thomas Goirand
Hi,

Is there any reason why the .mo files of Horizon are included in the
Git? IMO, they have nothing to do there. They take time to download, and
are the major causes of "git merge" failures for me when preparing
Havana packages. Removing the .mo files would also be a good step to
make sure we follow the guidelines of Debian (as binary generated files
could be considered non-free, and we should make sure everything is
built from source).

So, shouldn't the .mo files be generated at build time only, and be kept
out of the Git?

Cheers,

Thomas Goirand (zigo)

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Matt Riedemann
Thomas,

+1

I don't know anything about the background here, but for what it's worth, I work with a team that packages RPMs for the core components (nova, keystone, etc) and we only compile the mo's at rpmbuild time, nothing binary is stored in git, only the .po files (which are converted to .mo's using babel compile_catalog).



Thanks,

MATT RIEDEMANN
Advisory Software Engineer
Cloud Solutions and OpenStack Development

Phone: 1-507-253-7622 | Mobile: 1-507-990-1889
E-mail:
mriedem@...
IBM

3605 Hwy 52 N
Rochester, MN 55901-1407
United States





From:        Thomas Goirand <[hidden email]>
To:        OpenStack Development Mailing List <[hidden email]>,
Date:        07/01/2013 12:29 PM
Subject:        [openstack-dev] [horizon] Removing the .mo files from Horizon git




Hi,

Is there any reason why the .mo files of Horizon are included in the
Git? IMO, they have nothing to do there. They take time to download, and
are the major causes of "git merge" failures for me when preparing
Havana packages. Removing the .mo files would also be a good step to
make sure we follow the guidelines of Debian (as binary generated files
could be considered non-free, and we should make sure everything is
built from source).

So, shouldn't the .mo files be generated at build time only, and be kept
out of the Git?

Cheers,

Thomas Goirand (zigo)

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Thierry Carrez
In reply to this post by Thomas Goirand
Thomas Goirand wrote:
> So, shouldn't the .mo files be generated at build time only, and be kept
> out of the Git?

+1

--
Thierry Carrez (ttx)

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Mark McLoughlin
On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
> Thomas Goirand wrote:
> > So, shouldn't the .mo files be generated at build time only, and be kept
> > out of the Git?
>
> +1

Yep, agree too.

Interestingly, last time I checked, devstack doesn't actually compile
the message catalogs (python setup.py compile_catalog).

I've been meaning to fix that for a while now, but it's fallen by the
wayside. I've unassigned myself from the bug for now:

  https://bugs.launchpad.net/devstack/+bug/995287

Cheers,
Mark.


_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Monty Taylor


On 07/02/2013 01:13 AM, Mark McLoughlin wrote:

> On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
>> Thomas Goirand wrote:
>>> So, shouldn't the .mo files be generated at build time only, and be kept
>>> out of the Git?
>>
>> +1
>
> Yep, agree too.
>
> Interestingly, last time I checked, devstack doesn't actually compile
> the message catalogs (python setup.py compile_catalog).
>
> I've been meaning to fix that for a while now, but it's fallen by the
> wayside. I've unassigned myself from the bug for now:
>
>   https://bugs.launchpad.net/devstack/+bug/995287

Should we make python setup.py install do this if gettext is installed?
Or keep it as a separate step for people who care?

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Thomas Goirand
On 07/03/2013 02:15 AM, Monty Taylor wrote:

>
>
> On 07/02/2013 01:13 AM, Mark McLoughlin wrote:
>> On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
>>> Thomas Goirand wrote:
>>>> So, shouldn't the .mo files be generated at build time only, and be kept
>>>> out of the Git?
>>>
>>> +1
>>
>> Yep, agree too.
>>
>> Interestingly, last time I checked, devstack doesn't actually compile
>> the message catalogs (python setup.py compile_catalog).
>>
>> I've been meaning to fix that for a while now, but it's fallen by the
>> wayside. I've unassigned myself from the bug for now:
>>
>>   https://bugs.launchpad.net/devstack/+bug/995287
>
> Should we make python setup.py install do this if gettext is installed?
> Or keep it as a separate step for people who care?

FYI: https://review.openstack.org/#/c/35330/

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Julie Pichon
In reply to this post by Monty Taylor
"Monty Taylor" <[hidden email]> wrote:

> On 07/02/2013 01:13 AM, Mark McLoughlin wrote:
> > On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
> >> Thomas Goirand wrote:
> >>> So, shouldn't the .mo files be generated at build time only, and be kept
> >>> out of the Git?
> >>
> >> +1
> >
> > Yep, agree too.
> >
> > Interestingly, last time I checked, devstack doesn't actually compile
> > the message catalogs (python setup.py compile_catalog).
> >
> > I've been meaning to fix that for a while now, but it's fallen by the
> > wayside. I've unassigned myself from the bug for now:
> >
> >   https://bugs.launchpad.net/devstack/+bug/995287
>
> Should we make python setup.py install do this if gettext is installed?
> Or keep it as a separate step for people who care?

Yes, it would be awesome to automate this on install and let people still get the translations automagically.

Julie

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Zhenguo Niu
+1


On Wed, Jul 3, 2013 at 4:40 PM, Julie Pichon <[hidden email]> wrote:
"Monty Taylor" <[hidden email]> wrote:
> On 07/02/2013 01:13 AM, Mark McLoughlin wrote:
> > On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
> >> Thomas Goirand wrote:
> >>> So, shouldn't the .mo files be generated at build time only, and be kept
> >>> out of the Git?
> >>
> >> +1
> >
> > Yep, agree too.
> >
> > Interestingly, last time I checked, devstack doesn't actually compile
> > the message catalogs (python setup.py compile_catalog).
> >
> > I've been meaning to fix that for a while now, but it's fallen by the
> > wayside. I've unassigned myself from the bug for now:
> >
> >   https://bugs.launchpad.net/devstack/+bug/995287
>
> Should we make python setup.py install do this if gettext is installed?
> Or keep it as a separate step for people who care?

Yes, it would be awesome to automate this on install and let people still get the translations automagically.

Julie

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



--
Best Regards,
NiuZG

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Matt Riedemann
In reply to this post by Monty Taylor
If you use Babel, I don't think you need gettext by itself since I thought Babel has it's own conversion/compile code built-in?



Thanks,

MATT RIEDEMANN
Advisory Software Engineer
Cloud Solutions and OpenStack Development

Phone: 1-507-253-7622 | Mobile: 1-507-990-1889
E-mail:
mriedem@...
IBM

3605 Hwy 52 N
Rochester, MN 55901-1407
United States





From:        Monty Taylor <[hidden email]>
To:        [hidden email],
Date:        07/02/2013 01:22 PM
Subject:        Re: [openstack-dev] [horizon] Removing the .mo files from Horizon git






On 07/02/2013 01:13 AM, Mark McLoughlin wrote:
> On Tue, 2013-07-02 at 09:58 +0200, Thierry Carrez wrote:
>> Thomas Goirand wrote:
>>> So, shouldn't the .mo files be generated at build time only, and be kept
>>> out of the Git?
>>
>> +1
>
> Yep, agree too.
>
> Interestingly, last time I checked, devstack doesn't actually compile
> the message catalogs (python setup.py compile_catalog).
>
> I've been meaning to fix that for a while now, but it's fallen by the
> wayside. I've unassigned myself from the bug for now:
>
>  
https://bugs.launchpad.net/devstack/+bug/995287

Should we make python setup.py install do this if gettext is installed?
Or keep it as a separate step for people who care?

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Thomas Goirand
On 07/04/2013 10:14 AM, Matt Riedemann wrote:
> If you use Babel, I don't think you need gettext by itself since I
> thought Babel has it's own conversion/compile code built-in?

But why would you use something in Python, when GNU gettext in C does
the job lightning fast, and is available everywhere?

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Thomas Goirand
In reply to this post by Matt Riedemann
On 07/04/2013 10:14 AM, Matt Riedemann wrote:
> If you use Babel, I don't think you need gettext by itself since I
> thought Babel has it's own conversion/compile code built-in?

But why would you use something in Python, when GNU gettext in C does
the job lightning fast, and is available everywhere?

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|

Re: [horizon] Removing the .mo files from Horizon git

Matt Riedemann
I use Babel simply because the setup.cfg on the core projects are already configured for running babel so all I have to do to generate the .mo files is "python setup.py compile_catalog".



Thanks,

MATT RIEDEMANN
Advisory Software Engineer
Cloud Solutions and OpenStack Development

Phone: 1-507-253-7622 | Mobile: 1-507-990-1889
E-mail:
mriedem@...
IBM

3605 Hwy 52 N
Rochester, MN 55901-1407
United States





From:        Thomas Goirand <[hidden email]>
To:        OpenStack Development Mailing List <[hidden email]>,
Date:        07/04/2013 08:15 AM
Subject:        Re: [openstack-dev] [horizon] Removing the .mo files from Horizon git




On 07/04/2013 10:14 AM, Matt Riedemann wrote:
> If you use Babel, I don't think you need gettext by itself since I
> thought Babel has it's own conversion/compile code built-in?

But why would you use something in Python, when GNU gettext in C does
the job lightning fast, and is available everywhere?

Thomas

_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



_______________________________________________
OpenStack-dev mailing list
[hidden email]
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev