[qa][requirements][all] removing global pins for linters

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[qa][requirements][all] removing global pins for linters

Doug Hellmann-2
The recent thread about updating the pylint version in
global-requirements.txt raised an issue because it was trying to
update the pylint version for all projects using it, but some teams
were not ready for the new tests in the latest version. I thought
we had dealt with that kind of case in the past by treating linter
projects like pylint and flake8 as special cases, and leaving them
out of the global requirements list. The requirements repo has a
separate file (blacklist.txt) for projects that should not be synced
into repositories and tested against the global-requirements.txt
list, and pylint is included there along with several other linter
tools.

I'm not sure why the linters were also being added to
global-requirements.txt, but it seems like a mistake. I have proposed
a patch [2] to remove them, which should allow projects that want
to update pylint to do so while not forcing everyone to update at
the same time. If we find issues with the requirements sync after
removing the entries from the global list, we should fix the syncing
scripts so we can keep the linters blacklisted.

Doug

[1] http://lists.openstack.org/pipermail/openstack-dev/2017-June/118085.html
[2] https://review.openstack.org/473094

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [hidden email]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [qa][requirements][all] removing global pins for linters

Sean Dague-2
On 06/11/2017 11:30 AM, Doug Hellmann wrote:

> The recent thread about updating the pylint version in
> global-requirements.txt raised an issue because it was trying to
> update the pylint version for all projects using it, but some teams
> were not ready for the new tests in the latest version. I thought
> we had dealt with that kind of case in the past by treating linter
> projects like pylint and flake8 as special cases, and leaving them
> out of the global requirements list. The requirements repo has a
> separate file (blacklist.txt) for projects that should not be synced
> into repositories and tested against the global-requirements.txt
> list, and pylint is included there along with several other linter
> tools.
>
> I'm not sure why the linters were also being added to
> global-requirements.txt, but it seems like a mistake. I have proposed
> a patch [2] to remove them, which should allow projects that want
> to update pylint to do so while not forcing everyone to update at
> the same time. If we find issues with the requirements sync after
> removing the entries from the global list, we should fix the syncing
> scripts so we can keep the linters blacklisted.
>
> Doug
>
> [1] http://lists.openstack.org/pipermail/openstack-dev/2017-June/118085.html
> [2] https://review.openstack.org/473094

Are you sure that works as expected? My understanding is that the
requirements enforcement jobs only let you set requirements lines to
what are in that file. So that effectively prevents anyone from changing
the linters lines ever (see
http://logs.openstack.org/69/473369/1/check/gate-nova-requirements/b425844/console.html)

        -Sean

--
Sean Dague
http://dague.net

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [hidden email]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [qa][requirements][all] removing global pins for linters

Doug Hellmann-2
Excerpts from Sean Dague's message of 2017-06-12 07:09:12 -0400:

> On 06/11/2017 11:30 AM, Doug Hellmann wrote:
> > The recent thread about updating the pylint version in
> > global-requirements.txt raised an issue because it was trying to
> > update the pylint version for all projects using it, but some teams
> > were not ready for the new tests in the latest version. I thought
> > we had dealt with that kind of case in the past by treating linter
> > projects like pylint and flake8 as special cases, and leaving them
> > out of the global requirements list. The requirements repo has a
> > separate file (blacklist.txt) for projects that should not be synced
> > into repositories and tested against the global-requirements.txt
> > list, and pylint is included there along with several other linter
> > tools.
> >
> > I'm not sure why the linters were also being added to
> > global-requirements.txt, but it seems like a mistake. I have proposed
> > a patch [2] to remove them, which should allow projects that want
> > to update pylint to do so while not forcing everyone to update at
> > the same time. If we find issues with the requirements sync after
> > removing the entries from the global list, we should fix the syncing
> > scripts so we can keep the linters blacklisted.
> >
> > Doug
> >
> > [1] http://lists.openstack.org/pipermail/openstack-dev/2017-June/118085.html
> > [2] https://review.openstack.org/473094
>
> Are you sure that works as expected? My understanding is that the
> requirements enforcement jobs only let you set requirements lines to
> what are in that file. So that effectively prevents anyone from changing
> the linters lines ever (see
> http://logs.openstack.org/69/473369/1/check/gate-nova-requirements/b425844/console.html)
>
>     -Sean
>

Thanks. https://review.openstack.org/473402 should take care of that.

Doug

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: [hidden email]?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Loading...